-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ImageFont.getsize and related functions #6381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jun 30, 2022
radarhere
reviewed
Jun 30, 2022
radarhere
reviewed
Jun 30, 2022
radarhere
reviewed
Jun 30, 2022
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
for more information, see https://pre-commit.ci
Closed
5950269
to
729fe6f
Compare
Thanks for catching that. I've updated the commit, and it should be fixed now. |
Just to confirm, your intention is to put the deprecation message and suggested replacements in separate paragraphs, correct? |
It fixes the warning you mentioned, and is how we've done it in the past. |
20 tasks
hugovk
approved these changes
Jul 1, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Automatically merge PRs that are ready
Deprecation
Feature that will be removed in the future
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5816
Changes proposed in this pull request:
FreeTypeFont.getsize
andFreeTypeFont.getoffset
in favour ofFreeTypeFont.getbbox
andFreeTypeFont.getlength
FreeTypeFont.getsize_multiline
in favour ofImageDraw.Draw.multiline_textbbox
ImageFont.getsize
in favour of new functionsImageFont.getbbox
andImageFont.getlength
TransposedFont.getsize
in favour of new functionsTransposedFont.getbbox
andTransposedFont.getlength
ImageDraw.Draw.textsize
andImageDraw.Draw.multiline_textsize
in favour ofImageDraw.Draw.textbbox
,ImageDraw.Draw.multiline_textbbox
, andImageDraw.Draw.textlength
*bbox
and*length
functions, while also testing the old functions are deprecated and raise exactly one error even with nested callsFreeTypeFont.getsize
: https://pillow--6381.org.readthedocs.build/en/6381/reference/ImageFont.html#PIL.ImageFont.FreeTypeFont.getsize