Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added another crash image #39

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Added another crash image #39

merged 1 commit into from
Jun 29, 2021

Conversation

radarhere
Copy link
Member

See https://gitter.im/python-pillow/Pillow?at=60c83c69d20143617e46d162 for a report that one of the crash images from the main repository is triggering antivirus software.

As in #32, this PR adds crash images to this repository, to fix the problem. If this is merged, a PR can be created to remove the files from the main repository.

@hugovk
Copy link
Member

hugovk commented Jun 16, 2021

They say they filed a false positive with Microsoft, it would be best if it's resolved that way so we can keep the sdist as testable as possible on its own.

So shall we only include the actual problematic ones in this PR?

And it's only a couple of weeks until the next release, shall we check back in with the reporter a few days before release, and if it's not been resolved by MS, then merge?

@radarhere radarhere changed the title Added more crash images Added another crash image Jun 16, 2021
@radarhere
Copy link
Member Author

Sure, I've updated the commit to only include the reported image.

Be interesting to see if Microsoft does accept this as a false positive - they'd have to detect that a more recent version of Pillow is present on the system to understand that this is not a threat.

@hugovk
Copy link
Member

hugovk commented Jun 28, 2021

Two days until release. Please could you ping the original reporter? Thanks!

@radarhere
Copy link
Member Author

Sure, pinged them on gitter - https://gitter.im/python-pillow/Pillow?at=60d9b48eb60c3137c39812a6

@radarhere
Copy link
Member Author

Doesn't sound like Microsoft is going to resolve it - https://gitter.im/python-pillow/Pillow?at=60da4c58b60c3137c3997e19

@hugovk hugovk merged commit e6834ea into python-pillow:master Jun 29, 2021
@hugovk
Copy link
Member

hugovk commented Jun 29, 2021

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants