-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message of PyType_Spec deprecation warning with location #107810
Labels
triaged
The issue has been accepted as valid by a triager.
type-feature
A feature request or enhancement
Comments
At this moment we have access to if (PyErr_WarnFormat(
PyExc_DeprecationWarning, 1,
"Type %s uses PyType_Spec with metaclasses that have custom ",
"tp_new is deprecated and will no longer be allowed in "
"Python 3.14.", spec->name) < 0) {
goto finally; Does it enough? |
Also, I don't think it's a bug. It's looks like an enhancement ;) |
encukou
pushed a commit
that referenced
this issue
Aug 10, 2023
…new (GH-107834) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Aug 11, 2023
…om tp_new (pythonGH-107834) (cherry picked from commit 16dcce2) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Thanks everyone who contributed. The change has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
triaged
The issue has been accepted as valid by a triager.
type-feature
A feature request or enhancement
Bug report
A clear and concise description of the bug
Followup to #103968 (comment).
The DeprecationWarning for
PyType_Spec
in3.12.0rc1
is emitted on<frozen importlib._bootstrap>:400
which makes it quite difficult to know what package is responsible.In my particular case I found that, after reading #103968, it might be
protobuf
.And indeed that's how I can reproduce it.
To be clear, I don't mind the warning. I'm just wondering if it's possible to improve the error location.
/CC @encukou
--
The relevant CPython code
cpython/Objects/typeobject.c
Lines 4243 to 4249 in 3bb43b7
And protobuf where it's likely (?) created:
https://github.com/protocolbuffers/protobuf/blob/v4.24.0/python/google/protobuf/pyext/map_container.cc#L562
https://github.com/protocolbuffers/protobuf/blob/v4.24.0/python/google/protobuf/pyext/map_container.cc#L778
Your environment
3.12.0rc1
and with the latest3.12
commit: 3bb43b7Linked PRs
The text was updated successfully, but these errors were encountered: