bpo-35134: Move non-limited C API files to Include/cpython/ #24561
Conversation
Move
Include/{odictobject.h,parser_interface.h,picklebufobject.h,pydebug.h,pyfpe.h}
into Include/cpython/.
| @@ -0,0 +1,3 @@ | |||
| Move odictobject.h, parser_interface.h, picklebufobject.h, pydebug.h, and | |||
| pyfpe.h into the cpython/ directory. They must not be included directly, as | |||
| they are already included by Python.h: :ref:`Include Files <api-includes>`. | |||
There was a problem hiding this comment.
Hum. If we move more header files, the risk of breaking 3rd C extensions is higher. I'm still supportive of this change, but please document it also at C API > Porting to Python 3.10:
https://docs.python.org/dev/whatsnew/3.10.html#id2
In What's New in Python 3.10, document also the other header files that you already moved.
There was a problem hiding this comment.
Updated. I assume the main concern is if they have been included directly? I've worded my note with that in mind, but let me know if I should add anything else.
I've taken a quick look at the remaining files: there are still more than 10 header files that could be moved into cpython/ wholesale, and about the same number which require some surgery. Would you support making these changes (hopefully to close bpo-35134 entirely) within 3.10?
Parser/peg_api.c
Outdated
| @@ -1,4 +1,4 @@ | |||
| #include "parser_interface.h" | |||
| #include "cpython/parser_interface.h" | |||
There was a problem hiding this comment.
Can't we include Python.h here instead?
|
Merged, thanks. |
…-24561) Include/{odictobject.h,parser_interface.h,picklebufobject.h,pydebug.h,pyfpe.h} into Include/cpython/. Parser: peg_api: include Python.h instead of parser_interface.h.
Move
Include/{odictobject.h,parser_interface.h,picklebufobject.h,pydebug.h,pyfpe.h}
into Include/cpython/.
In the same vein as previous commits by @vstinner.
https://bugs.python.org/issue35134