Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43749: Ensure current exe is copied when using venv on windows #25216

Merged
merged 1 commit into from
May 19, 2021
Merged

bpo-43749: Ensure current exe is copied when using venv on windows #25216

merged 1 commit into from
May 19, 2021

Conversation

inorton
Copy link
Contributor

@inorton inorton commented Apr 6, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue43749

Automerge-Triggered-By: GH:vsajip

@inorton inorton requested a review from vsajip as a code owner April 6, 2021 14:02
@inorton inorton force-pushed the inorton-fix-43749_windows_venv_exes branch from 454b168 to 57065ee Compare April 6, 2021 14:35
vsajip
vsajip requested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the NEWS file, as I've added the skip-news label to this PR.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@inorton inorton force-pushed the inorton-fix-43749_windows_venv_exes branch from 57065ee to 0f3da17 Compare April 19, 2021 09:45
@inorton
Copy link
Contributor Author

inorton commented May 15, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip May 15, 2021 19:38
@miss-islington miss-islington merged commit 5d6e463 into python:main May 19, 2021
This was referenced Nov 10, 2021
Closed
Merged
@vsajip vsajip added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Dec 10, 2021
@miss-islington
Copy link
Contributor

Thanks @inorton for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @inorton for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-30033 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 10, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2021
@inorton @miss-islington
bpo-43749: Ensure current exe is copied when using venv on windows (p…
ab8bfaf 
…ythonGH-25216)

Automerge-Triggered-By: GH:vsajip
(cherry picked from commit 5d6e463)

Co-authored-by: Ian Norton <inorton@gmail.com>
@bedevere-bot
Copy link

GH-30034 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 10, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2021
@inorton @miss-islington
bpo-43749: Ensure current exe is copied when using venv on windows (p…
8c9aa4b 
…ythonGH-25216)

Automerge-Triggered-By: GH:vsajip
(cherry picked from commit 5d6e463)

Co-authored-by: Ian Norton <inorton@gmail.com>
vsajip pushed a commit that referenced this pull request Dec 10, 2021
@miss-islington @inorton
[3.10] bpo-43749: Ensure current exe is copied when using venv on win…
bb8d645 
…dows (GH-25216) (GH-30034)

Co-authored-by: Ian Norton <inorton@gmail.com>
vsajip pushed a commit that referenced this pull request Dec 10, 2021
@miss-islington @inorton
[3.9] bpo-43749: Ensure current exe is copied when using venv on wind…
bad16f0 
…ows (GH-25216) (GH-30033)

Co-authored-by: Ian Norton <inorton@gmail.com>
@stewartmiles stewartmiles mentioned this pull request Feb 29, 2024
Open
2 tasks
@inorton inorton mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inorton @bedevere-bot @miss-islington @vsajip @the-knights-who-say-ni