Resolve EncodingWarnings #14676
Draft
Resolve EncodingWarnings #14676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be appropriate to use |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
A5rocks
reviewed
Feb 11, 2023
Comment on lines
+20
to
+23
| with NamedTemporaryFile(delete=False) as tmp: | ||
| tmp.write(b"x: int = 5\n") | ||
| self.tmp_path = Path(tmp.name) | ||
| self.tmp_cache_dir = Path(mkdtemp()) |
There was a problem hiding this comment.
This will get run before every test in this test suite. Should this get moved into test_default_encoding_warnings?
In my opinion, "utf-8" almost always the best way to go. It provides more consistency across platforms. Only if the old behavior is truly needed (non-utf8 on Windows platforms) would you likely want "locale". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #14603
encodingshould be explicit, even when opting for the default behavior ("locale")https://peps.python.org/pep-0597/
This is motivated by eliminating
EncodingWarnings inpytest-mypy.