Add and implement primitive list.copy() #18771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the primitive list.copy() method
added list.copy()
creates a test for list.copy()
fixture for list.copy()
creates a test for list.copy() renamed for missing .test extension
fixture for list.copy()
cdce8p
reviewed
Mar 8, 2025
mypyc/lib-rt/list_ops.c
Outdated
| return PyList_GetSlice(list, 0, PyList_GET_SIZE(list)); | ||
| } | ||
| _Py_IDENTIFIER(copy); | ||
| return _PyObject_CallMethodIdNoArgs(list, &PyId_copy); |
There was a problem hiding this comment.
I'm trying to get rid of _PyObject_CallMethodIdNoArgs as it's only an internal method. See #18761 It would be better to use PyObject_CallMethodNoArgs here instead.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add primitive for list.copy #1092