Enable Ruff PLR (Pylint Refactor) #13307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avasam
changed the title
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Jan 2, 2025
AlexWaygood
reviewed
Jan 2, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Feb 27, 2025
srittau
reviewed
Feb 27, 2025
This comment has been minimized.
This comment has been minimized.
|
This has (not suprisingly) conflicts after merging #13306. |
srittau
approved these changes
Mar 3, 2025
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13295
https://docs.astral.sh/ruff/rules/#refactor-r
There's a few nice automated fixes between more concise conditions and imports.
magic-value-comparison (PLR2004) is a harder call. It found some magic numbers that definitely should use
HTTPStatus. But I also don't think creating constants for literal2is worth it.Even at work we allow
2literals in our ESLint configs for JS/TS.There's an open issue to make this configurable per-literal: astral-sh/ruff#10009
We could noqa, disable it globally, or wait for a resolution on that Ruff issue.