-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spyder to project list and timeline #141
Add Spyder to project list and timeline #141
Conversation
site.js
Outdated
@@ -135,6 +135,11 @@ $(document).ready(function (){ | |||
{content: '3.1', start: '2019-01-01', end: '2019-07-01'}, | |||
{content: '3.2', start: '2019-07-01', end: '2020-01-01'} | |||
], | |||
'Spyder':[ | |||
{content: '3', start: '2016-09-24', end: '2019-03-01', py2:true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the end date of our 3 series is going to be 2018-12-01.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that defines the "support" date as the day of the last scheduled release, unlike the convention followed by every other project on this list, and it will leave a gap between them, rather than being supported at least until the release of the following version (i.e. leaving no version of Spyder "supported" during the transition period). Even if the last scheduled release is on that date, we would naturally support Spyder 3 (e.g. via Github, Gitter, Google Groups, Docs, and possibly emergency fixes if necessary) at least until the release of Spyder 4. It wouldn't make any sense to do otherwise.
Therefore, I propose an end date of at least 2019-01-15, the same day on which Spyder 4 is scheduled for release (although at least in practice, we'd want to consider the delay to get conda
packages out, possible emergency fixes, at least some latency in all users upgrading to a new major version on the day of its release, etc.).
site.js
Outdated
@@ -135,6 +135,11 @@ $(document).ready(function (){ | |||
{content: '3.1', start: '2019-01-01', end: '2019-07-01'}, | |||
{content: '3.2', start: '2019-07-01', end: '2020-01-01'} | |||
], | |||
'Spyder':[ | |||
{content: '3', start: '2016-09-24', end: '2019-03-01', py2:true}, | |||
{content: '4', start: '2019-02-01', end: '2020-02-01', py2:true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be start: 2019-01-15
, end: 2019-12-15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the above reasoning, we would want to shift the end date to at least the start date of the next version, 2019-12-31.
site.js
Outdated
'Spyder':[ | ||
{content: '3', start: '2016-09-24', end: '2019-03-01', py2:true}, | ||
{content: '4', start: '2019-02-01', end: '2020-02-01', py2:true}, | ||
{content: '5', start: '2019-12-31', end: '2021-12-16'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @CAM-Gerlach! |
@ccordoba12 See my above comments. Implemented start dates per your feedback and end dates as proposed above, but if you really want something different I can change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach!
This is thus ready to merge on our end, FYI. |
Merging! thanks. |
This PR adds Spyder, a popular (>100,000s users) data science IDE (and an ecosystem of plugins and related projects) to the project list and the support timeline.
With 3.3k stars (and likely a much higher ratio of users to stars, given its status as a graphical IDE) it was placed below Jupyter notebook (4.4k stars) and above Scikit-image (2.4k stars), which also makes sense due to its conceptual link to the former. Similarly, in the timeline, it was placed below Matplotlib (7.6k stars) and above Xonsh (2.4k stars); again, it is more closely associated with the former members of the PyData stack than those listed after.
Please hold off on merging until our maintainer, Carlos Cordoba ( @ccordoba12 ) double-checks the dates. Thanks!Done!