Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added list clearing FX codegen for backwards in AOTAutograd. #779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added list clearing FX codegen for backwards in AOTAutograd. #779

wants to merge 2 commits into from

Conversation

Chillee
Copy link
Contributor

@Chillee Chillee commented May 5, 2022

No description provided.

@Chillee Chillee mentioned this pull request May 5, 2022
Closed
ngimel
ngimel approved these changes Jun 22, 2022
View reviewed changes
Copy link

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Chillee
Copy link
Contributor Author

Chillee commented Jun 29, 2022 •
edited
Loading

Note: I've currently not bothered to land this PR, as Torchscript seems to keep all of the input activations alive.

We've verified that this reduces memory usage as expected if the graph isn't compiled with Torchscript: albanD/subclass_zoo#41

image

yushangdi added a commit to pytorch/pytorch that referenced this pull request Aug 8, 2022
@yushangdi
use patch pytorch/functorch#779
1b6c776
@facebook-github-bot
Copy link

Hi @Chillee!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chillee @facebook-github-bot @ngimel