-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added resolution to SwathDefinition in slice.py #650
base: main
Are you sure you want to change the base?
Conversation
I could be wrong and @mraspaud or @pnuu may have to correct me but I think the slicer stuff is not meant to support SwathDefinitions by design. I could be forgetting what this code is used for though so forgive me if so. A swath is not guaranteed to have contiguous pixels and therefore can't/shouldn't be sliced by geolocation/lon/lat bounds. |
Sorry, I should have also said thank you for making this PR. Even if I am right this should start the discussion to supporting what you're trying to do and is probably a discussion that we need to have. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 93.98% 93.97% -0.01%
==========================================
Files 86 86
Lines 13543 13545 +2
==========================================
+ Hits 12728 12729 +1
- Misses 815 816 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looking at the diff, the only actual change is the addition of the resolution. The other bits are just reformatting. So I think the addition of the resolution is in the wrong place. This is now done to Also, I'd say the resolution shouldn't be hard-coded to |
Maybe we should take a step back. @nilssonjacob what is your use case? What code are you running that isn't working? |
Adds resolution to area if the area to contain is of type SwathDefinition to avoid crashing.