fix: gang/job validation #1111
Merged
fix: gang/job validation #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has come to my attention that there are ways for the job data to become unsynced.
Such as the
isbossvalue being saved as false, even though it's true in the shared files.(Via no kidding at least 20 tickets of said issue concerning my boss menu and qbcore's
isbossstate)I'd imagine this can more specifically be recreated via already having a job, and then said jobs shared data being changed, whilst your "locally" saved player job data wouldn't update.
Therefore this PR aims to introduce validation of said data, to make sure it never ever gets out of sync.
Checklist