-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable not defined in mpldrawer
#1437
Comments
Thanks for spotting this! @sergiomtzlosa, should we pass the circuit as an argument so that we keep that line or do you think we can do that in a different way? |
sorry @renatomello and @MatteoRobbiati ! I did not spot this, I just submit a commit to fix this bug |
Yeah, unfortunately we didn't notice because the CI was not running, since the PR came from a fork. However, this should not happen for new PRs, even from forks. If that's not the case, please report it to me or @scarrazza |
No problem. Are you going to open a PR for this? |
yes! here is the pull request #1438 |
Matplotlib drawer: fix bug #1437 and add tests
@MatteoRobbiati @sergiomtzlosa
PR #1370 introduced the new
ui
module tomaster
. There is a helper function in the module that is raising alint
error due to an undefined variable. The specific line is this one. This is preventing tests from passing, e.g. https://github.com/qiboteam/qibo/actions/runs/10715691273/job/29711648870The text was updated successfully, but these errors were encountered: