Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qibotn option #1243

Merged
merged 13 commits into from
Mar 2, 2024
Merged

Add qibotn option #1243

merged 13 commits into from
Mar 2, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Mar 1, 2024

@Tankya2 @liweintu sorry for the mess: I was cleaning up the branches of the merged PRs, and I didn't notice that #1235 was not pointing to master automatically, but still pointing to the old branch (that I deleted).

@Tankya2
Copy link
Contributor

Tankya2 commented Mar 1, 2024

@Tankya2 @liweintu sorry for the mess: I was cleaning up the branches of the merged PRs, and I didn't notice that #1235 was not pointing to master automatically, but still pointing to the old branch (that I deleted).

I see, no worries @alecandido

@liweintu
Copy link

liweintu commented Mar 1, 2024

@Tankya2 @liweintu sorry for the mess: I was cleaning up the branches of the merged PRs, and I didn't notice that #1235 was not pointing to master automatically, but still pointing to the old branch (that I deleted).

No worries. Thanks for cleaning up the branches. Actually, I should've flagged it up 'cos I noticed it's not pointing to main. However, I thought it was intentional then.

Anyway, I approved it now.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we have to fix tests.

@scarrazza
Copy link
Member

@alecandido could you please double check my latest fix? If you agree we merge and finally unlock the qibo release.

from qibotn.backends.cutensornet import CuTensorNet # pylint: disable=E0401

return CuTensorNet(kwargs["runcard"])
elif platform == "qutensornet": # pragma: no cover
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, at this point we can remove this pragma.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ae3aa1) to head (77c0475).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines        10440     10440           
=========================================
  Hits         10440     10440           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido
Copy link
Member Author

@alecandido could you please double check my latest fix? If you agree we merge and finally unlock the qibo release.

Yes, that's exactly how I remembered it.

@scarrazza scarrazza added this pull request to the merge queue Mar 2, 2024
Merged via the queue into master with commit b991160 Mar 2, 2024
21 checks passed
@alecandido alecandido mentioned this pull request Mar 13, 2024
4 tasks
@scarrazza scarrazza deleted the qibotn_interface branch March 26, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants