-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qibotn option #1243
Add qibotn option #1243
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
d73074a
to
1c01ffa
Compare
I see, no worries @alecandido |
No worries. Thanks for cleaning up the branches. Actually, I should've flagged it up 'cos I noticed it's not pointing to Anyway, I approved it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but we have to fix tests.
@alecandido could you please double check my latest fix? If you agree we merge and finally unlock the qibo release. |
from qibotn.backends.cutensornet import CuTensorNet # pylint: disable=E0401 | ||
|
||
return CuTensorNet(kwargs["runcard"]) | ||
elif platform == "qutensornet": # pragma: no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, at this point we can remove this pragma.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 10440 10440
=========================================
Hits 10440 10440
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, that's exactly how I remembered it. |
@Tankya2 @liweintu sorry for the mess: I was cleaning up the branches of the merged PRs, and I didn't notice that #1235 was not pointing to
master
automatically, but still pointing to the old branch (that I deleted).