random_clifford casting qubits to python int
#1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 72 72
Lines 10560 10560
=======================================
Hits 10541 10541
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renatomello
approved these changes
May 29, 2024
There was a problem hiding this comment.
I don't think this alters anything important in the function, but @BrunoLiegiBastonLiegi can correct me if I'm wrong
BrunoLiegiBastonLiegi
approved these changes
May 29, 2024
renatomello
changed the title
random_clifford casting qubits to python int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the bug observed in qiboteam/qibo-client#39. It looks like the qubit numbers are stored as numpy.int64 instead of python int, therefore serialization with json does not work from the qibo-client side. Could you please confirm this patch is acceptable?
Checklist: