DBI 3rd order GCI #1342
Merged
DBI 3rd order GCI #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrightjandrew
requested review from
marekgluza,
andrea-pasquale,
MatteoRobbiati and
Sam-XiaoyueLi
for more information, see https://pre-commit.ci
…into dbi_gci_third_order
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 74 74
Lines 10747 10753 +6
=======================================
+ Hits 10730 10736 +6
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marekgluza
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Hi @wrightjandrew great, thanks so much! Can you please brush over the suggested doc string?
Please copy paste the final one into the PR main message around your plot.
…into dbi_gci_third_order
for more information, see https://pre-commit.ci
marekgluza
reviewed
Jun 7, 2024
| @@ -23,7 +23,12 @@ class DoubleBracketGeneratorType(Enum): | |||
| """Use single commutator.""" | |||
| group_commutator = auto() | |||
| """Use group commutator approximation""" | |||
| # TODO: add double commutator (does it converge?) | |||
| group_commutator_3 = auto() | |||
| """Implements: $e^{\frac{\\sqrt{5}-1}{2}sH}e^{\frac{\\sqrt{5}-1}{2}sD}e^{-sH}e^{sD}e^{\frac{3-\\sqrt{5}}{2}sH}e^{sD} | |||
There was a problem hiding this comment.
Suggested change
| """Implements: $e^{\frac{\\sqrt{5}-1}{2}sH}e^{\frac{\\sqrt{5}-1}{2}sD}e^{-sH}e^{sD}e^{\frac{3-\\sqrt{5}}{2}sH}e^{sD} | |
| """Implements: $e^{\frac{\\sqrt{5}-1}{2}isH}e^{\frac{\\sqrt{5}-1}{2}isD}e^{-sH}e^{isD}e^{\frac{3-\\sqrt{5}}{2}isH}e^{isD} |
| # TODO: add double commutator (does it converge?) | ||
| group_commutator_3 = auto() | ||
| """Implements: $e^{\frac{\\sqrt{5}-1}{2}sH}e^{\frac{\\sqrt{5}-1}{2}sD}e^{-sH}e^{sD}e^{\frac{3-\\sqrt{5}}{2}sH}e^{sD} | ||
| \approx e^{s^2[H,D]} + O(s^4)$ |
There was a problem hiding this comment.
I think just a minus sign
for more information, see https://pre-commit.ci
Edoardo-Pedicillo
approved these changes
Jun 7, 2024
…into dbi_gci_third_order
andrea-pasquale
approved these changes
Jun 7, 2024
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
…into dbi_gci_third_order
marekgluza
approved these changes
Jun 10, 2024
|
@andrea-pasquale @Edoardo-Pedicillo can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the third order GCI formula to the double blacket flow class. We probably need to change the name in the class :)