-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expectation values as native backend arrays #1382
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
=========================================
Coverage ? 97.11%
=========================================
Files ? 81
Lines ? 11699
Branches ? 0
=========================================
Hits ? 11362
Misses ? 337
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qiboml
models related fixesCo-authored-by: Renato Mello <renato.msf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just left a comment about the optimizer choice.
This updates the expectation values calculation, that are now computed and returned as native arrays of the backend used. This, in turns, begs for updating some of the error mitigation methods accordingly. In particular, as
torch
was having problems with thescipy.curve_fit
I had to implement a custom_curve_fit
based on thetorch.optim.LBFGS
optimizer.Checklist: