Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #1411

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 5, 2024

@alecandido
Copy link
Member

The problem in the workflows is generated by an issue on Matplotlib side, which led to yanking the release
https://pypi.org/project/matplotlib/3.9.1/
matplotlib/matplotlib#28551

I will try to regenerate the lock file to solve the issue, but it's unrelated to this update.

@alecandido alecandido requested a review from scarrazza August 6, 2024 05:58
@alecandido
Copy link
Member

@scarrazza do not merge yet: I approved the update, since it's good, but I'm still attempting to solve the problem above.

@QuLogic
Copy link

QuLogic commented Aug 7, 2024

There are new Matplotlib wheels on PyPI now; you can probably just re-run your tests.

@alecandido
Copy link
Member

There are new Matplotlib wheels on PyPI now; you can probably just re-run your tests.

Thanks @QuLogic, I just tried. However, I'm skeptical, because I may have to at least update the lock file, since it's being used in the workflow.

@alecandido alecandido mentioned this pull request Aug 7, 2024
@QuLogic
Copy link

QuLogic commented Aug 7, 2024

Ah yes, if you have locks, then you'll probably want to update those to 3.9.1.post1.

@alecandido alecandido force-pushed the pre-commit-ci-update-config branch from 275438b to 9779d36 Compare August 7, 2024 06:46
@alecandido alecandido changed the base branch from master to matplotlib-update August 7, 2024 06:46
@alecandido
Copy link
Member

Ok, this should be merged after #1413

@alecandido
Copy link
Member

Ah yes, if you have locks, then you'll probably want to update those to 3.9.1.post1.

I was not sure about the behavior of locks with yanked and post versions, whether it would have tried to force the yank one, just fail, or promote automatically.
Promotion would defy the aim of locks, and indeed did not happen. But it didn't fail because it was yanked, and tried to force the download. Which was also a bit unexpected...

updates:
- [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0)
@alecandido alecandido force-pushed the pre-commit-ci-update-config branch from 9779d36 to 528abe3 Compare August 7, 2024 16:34
@alecandido alecandido changed the base branch from matplotlib-update to master August 7, 2024 16:34
@alecandido alecandido added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit 259380d Aug 7, 2024
25 checks passed
@alecandido alecandido deleted the pre-commit-ci-update-config branch August 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants