Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculate_singular_value_decompositon as a backend method #1473

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 4, 2024

This is needed in #1471

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2024
@renatomello renatomello self-assigned this Oct 4, 2024
@renatomello renatomello marked this pull request as draft October 4, 2024 09:04
@renatomello renatomello requested a review from stavros11 October 4, 2024 09:22
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (a59e5d7) to head (af57061).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11777    11786    +9     
=======================================
+ Hits        11769    11778    +9     
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit 2144add Oct 8, 2024
27 checks passed
@renatomello renatomello deleted the svd branch October 17, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants