Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to check toml files #1480

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add hook to check toml files #1480

merged 1 commit into from
Oct 8, 2024

Conversation

alecandido
Copy link
Member

The hook is one of the default ones, and essentially for free. It will mainly help keeping pyproject.toml formatted.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@alecandido
Copy link
Member Author

Ok, I was joking, it's just verifying the syntax, it's not formatting anything.

To get the formatting part, we'd need something like:
https://github.com/toml-lang/toml/blob/dc5af251cd348ee053d9355359743767e3d0b123/.pre-commit-config.yaml#L2-L5
or
https://github.com/ComPWA/taplo-pre-commit
but they are not "for free", so I'm not going to propose them (for the time being).

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also propagate to other repos (if not already there).

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (3a7a951) to head (a922b8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11800    11800           
=======================================
  Hits        11792    11792           
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido
Copy link
Member Author

Maybe we could also propagate to other repos (if not already there).

That's exactly why I appointed you as a reviewer :)

@alecandido alecandido added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit fa9ee31 Oct 8, 2024
28 checks passed
@renatomello renatomello deleted the pre-commit-check-toml branch October 17, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants