Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quantum_fisher_information_matrix to quantum_info.metrics #1487

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 14, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Oct 14, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Oct 14, 2024
@renatomello renatomello self-assigned this Oct 14, 2024
@renatomello renatomello linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm essentially fine with it, just a few minor comments.

@alecandido
Copy link
Member

Ah, the tests are not passing (because of the linter), that should be fixed (of course - but the CI is already there to remind you...).

@alecandido
Copy link
Member

Btw, @MatteoRobbiati, pay attention to this PR, since it will affect the TensorFlow/Pytorch backend migration to Qiboml.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (e7276d8) to head (7fe3d1f).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1487   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11795    11834   +39     
=======================================
+ Hits        11787    11826   +39     
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello marked this pull request as ready for review October 15, 2024 08:53
@renatomello renatomello added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit b5aabcc Oct 16, 2024
27 checks passed
@renatomello renatomello deleted the qfim branch October 16, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quantum Fisher Information Matrix
3 participants