-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quantum_fisher_information_matrix
to quantum_info.metrics
#1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm essentially fine with it, just a few minor comments.
Ah, the tests are not passing (because of the linter), that should be fixed (of course - but the CI is already there to remind you...). |
Btw, @MatteoRobbiati, pay attention to this PR, since it will affect the TensorFlow/Pytorch backend migration to Qiboml. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 81 81
Lines 11795 11834 +39
=======================================
+ Hits 11787 11826 +39
Misses 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Checklist: