Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hamming_weight_encoder to models.encodings #1560

Merged
merged 14 commits into from
Jan 27, 2025
Merged

Add hamming_weight_encoder to models.encodings #1560

merged 14 commits into from
Jan 27, 2025

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jan 22, 2025 •
edited
Loading

Reference

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 22, 2025
@renatomello renatomello added this to the Qibo 0.2.16 milestone Jan 22, 2025
@renatomello renatomello self-assigned this Jan 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (cbcee14) to head (6e75310).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #1560    +/-   ##
========================================
  Coverage   99.68%   99.68%            
========================================
  Files          76       76            
  Lines       11280    11386   +106     
========================================
+ Hits        11244    11350   +106     
  Misses         36       36
Flag Coverage Δ
unittests 99.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Edoardo-Pedicillo
Edoardo-Pedicillo approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@renatomello renatomello marked this pull request as ready for review January 23, 2025 06:49
BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi reviewed Jan 23, 2025
View reviewed changes
renatomello and others added 3 commits January 24, 2025 09:37
@renatomello @BrunoLiegiBastonLiegi
Update src/qibo/models/encodings.py
8d26bb9 
Co-authored-by: BrunoLiegiBastonLiegi <45011234+BrunoLiegiBastonLiegi@users.noreply.github.com>
@renatomello @BrunoLiegiBastonLiegi
Update src/qibo/models/encodings.py
0e1146d 
Co-authored-by: BrunoLiegiBastonLiegi <45011234+BrunoLiegiBastonLiegi@users.noreply.github.com>
@renatomello
andrea's suggestions
2874b04
@renatomello renatomello added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 32f85da Jan 27, 2025
27 checks passed
@renatomello renatomello deleted the hwk_encoder branch January 29, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@Edoardo-Pedicillo Edoardo-Pedicillo Edoardo-Pedicillo approved these changes

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

@andre-juan andre-juan Awaiting requested review from andre-juan

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.16
Development

Successfully merging this pull request may close these issues.
3 participants
@renatomello @BrunoLiegiBastonLiegi @Edoardo-Pedicillo