-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selfhosted GPU tests restricted to GPU backends only #1579
Conversation
Run on QPU
|
Ok now the gpu tests take ~6 minutes to complete. Should we include even the pytorch and tensorflow (I don't think we have gpu support for jax yet) gpu tests? |
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
If you want feel free to do so, however if we see that tests are not passing for PyTorch and tensorflow we can address them in another PR. |
Run on QPU
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1579 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 76 76
Lines 11449 11449
=======================================
Hits 11405 11405
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The thing is that right now I am not even sure how well is integrated the use of a device in the torch and tf backend. For example: from qibo import set_backend
from qibo.models import QFT
set_backend(backend="qiboml", platform="pytorch")
c = QFT(5)
r = c()
r.probabilities().device
# device(type='cpu')
r.state().device
# device(type='cpu') and the same happens for tensorflow. |
At this point I agree we can skip it, just open an issue so that we don't forget. |
Same as qiboteam/qibojit#206. A
--gpu-only
option is added to pytest to run tests on GPU backends only.Checklist: