-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation instructions for cuQuantum backend #534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 85
Lines 12439 12439
=========================================
Hits 12439 12439
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me, only one comment.
dependencies except `cupy <https://cupy.dev/>`_ and | ||
`cuQuantum <https://developer.nvidia.com/cuquantum-sdk>`_ | ||
which are required for GPU acceleration. Please install `cupy <https://cupy.dev/>`_ by following the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we clarify that our cuquantum
backend is an alternative GPU implementation, so that installing it is not required to have GPU acceleration (in contrast to cupy
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Marco's comment, we can add a sentence where we say that cuquantum is optional. Other than that it looks good, thanks.
In #533 I document how one can switch between cupy and cuquantum using qibo.set_backend()
. At some point we should also document the default switch using environment variables, along with other environment variables we have in qibo. I'm not sure if this should be done here or in a different PR.
Thank you both for the feedback!
If you want to add it directly to #533 I am fine with it. Otherwise I can add everything related to the documentation directly here. |
@andrea-pasquale thanks, if you include the |
Co-authored-by: Stefano Carrazza <scarrazza@users.noreply.github.com>
Thanks for the feedback. I've added your suggestions. |
This PR is related to the cuQuantum backend from qiboteam/qibojit#57.
I've updated the installation instructions and I've added cuQuantum along the other platforms available in qibojit.
Let me know what you think.