-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove example runcards #1015
Remove example runcards #1015
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 97.46% 97.53% +0.06%
==========================================
Files 123 123
Lines 9722 9722
==========================================
+ Hits 9476 9482 +6
+ Misses 246 240 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Edoardo-Pedicillo.
Before merging couldyou please update also the documentation?
There in an explicit reference to the runcards
folder that you removed in this file
https://github.com/qiboteam/qibocal/blob/clean_runcards/doc/source/getting-started/
example.rst
EDIT: also here https://github.com/qiboteam/qibocal/tree/main/runcards/calibration_tutorial
After an internal discussion, we agreed to remove all the runcards that are not used in the documentation and testing, to have smoother maintainability.
Since the folder
runcards
does not contain runcards anymore, I have recalled it ascalibration_scripts
Checklist:
master
main
main