Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example runcards #1015

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Remove example runcards #1015

merged 4 commits into from
Oct 28, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Oct 17, 2024

After an internal discussion, we agreed to remove all the runcards that are not used in the documentation and testing, to have smoother maintainability.

Since the folder runcards does not contain runcards anymore, I have recalled it as calibration_scripts

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as draft October 17, 2024 13:50
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (bb83a11) to head (ffec1c0).
Report is 57 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
+ Coverage   97.46%   97.53%   +0.06%     
==========================================
  Files         123      123              
  Lines        9722     9722              
==========================================
+ Hits         9476     9482       +6     
+ Misses        246      240       -6     
Flag Coverage Δ
unittests 97.53% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Oct 18, 2024
@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review October 21, 2024 13:10
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo.
Before merging couldyou please update also the documentation?
There in an explicit reference to the runcards folder that you removed in this file
https://github.com/qiboteam/qibocal/blob/clean_runcards/doc/source/getting-started/
example.rst

EDIT: also here https://github.com/qiboteam/qibocal/tree/main/runcards/calibration_tutorial

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit fa0467c Oct 28, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the clean_runcards branch October 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants