Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2q tomography #1035

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix 2q tomography #1035

merged 2 commits into from
Nov 4, 2024

Conversation

stavros11
Copy link
Member

Fixes #1032. I have not tested how this affect results from hardware, but it is quite clear that the fix is needed (otherwise the real and imaginary part are not compatible).

I also updated the docstring of the _fit method with more clear descriptions of the process steps, instead of the wikipedia link, which I think was more confusing than helping.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (74d2625) to head (720a73e).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   97.33%   97.30%   -0.04%     
==========================================
  Files         120      120              
  Lines        9747     9747              
==========================================
- Hits         9487     9484       -3     
- Misses        260      263       +3     
Flag Coverage Δ
unittests 97.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/qibocal/protocols/two_qubit_state_tomography.py 99.29% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavros11 , LGTM.

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 39e5d3c Nov 4, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the fix-2q-tomography branch November 4, 2024 09:55
@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two qubit state tomography reporting incorrect density matrix
3 participants