Mermin refactor #1038

Edoardo-Pedicillo · 2024-11-05T17:35:24Z

@igres26 I have opened this PR to track the Mermin refactoring.
I have some questions:

Could you explain this hard-coded value ?

qibocal/src/qibocal/protocols/two_qubit_interaction/mermin/pulses.py

Line 30 in 3219031

[qubits[0]] + [qubits[i]], sequence.finish + 8
In Generalizing Mermin to n qubits and adding theta angles for plot #1005, the mitigation matrix is evaluated but not saved. Do you want to use it?
Can we choose only one between Mermin with pulses and circuits? (we have already quite discussed about it, but could be better to answer here, since other people could be interested) I am refactoring the pulse one and have deleted the other one because only the first one was tested, but maybe it would be nice to have only the second one.

Checklist:

Reviewers confirm new code works as expected.
Tests are passing.
Coverage does not decrease.
Documentation is updated.
Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
- Qibo: master
- Qibolab: 0.1
- Qibolab_platforms_qrc: 0.1

for more information, see https://pre-commit.ci

alecandido · 2024-11-06T05:55:13Z

Can we choose only one between Mermin with pulses and circuits? (we have already quite discussed about it, but could be better to answer here, since other people could be interested) I am refactoring the pulse one and have deleted the other one because only the first one was tested, but maybe it would be nice to have only the second one.

Just to add my 2c: whenever the circuits expression is supposed to be equivalent (i.e. usually the original protocol's definition is given in terms of circuits), it'd be better to express anything as circuits, as the higher level abstraction.
However, this certainly relies on the compiler to be doing its job, and sometimes the transpiler as well. I acknowledge this can be non-trivial. In general, if you encounter issues, feel free to use any workaround you need, but please report why you had to, and document it even in Qibocal (anywhere, an issue, or even a document in https://github.com/qiboteam/qibocal/tree/main/doc/dev). In principle, there should be no need for manual compilation (& transpilation), also because this will be the execution setup as well.

Edoardo-Pedicillo · 2024-11-06T09:12:09Z

ust to add my 2c: whenever the circuits expression is supposed to be equivalent (i.e. usually the original protocol's definition is given in terms of circuits), it'd be better to express anything as circuits, as the higher level abstraction.
However, this certainly relies on the compiler to be doing its job, and sometimes the transpiler as well. I acknowledge this can be non-trivial. In general, if you encounter issues, feel free to use any workaround you need, but please report why you had to, and document it even in Qibocal (anywhere, an issue, or even a document in https://github.com/qiboteam/qibocal/tree/main/doc/dev). In principle, there should be no need for manual compilation (& transpilation), also because this will be the execution setup as well.

I agree, but from what I understood, there are some discrepancies. Maybe @igres26 could elaborate more on this.

Edoardo-Pedicillo · 2024-11-13T07:32:23Z

After #1040 I think we can use circuits

codecov · 2024-11-14T13:10:42Z

Codecov Report

Attention: Patch coverage is 99.09910% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (c8cd2a9) to head (407d537).
Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
...l/protocols/two_qubit_interaction/mermin/pulses.py	97.14%	1 Missing ⚠️
...al/protocols/two_qubit_interaction/mermin/utils.py	96.29%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   97.37%   97.32%   -0.06%     
==========================================
  Files         120      124       +4     
  Lines        9749     9893     +144     
==========================================
+ Hits         9493     9628     +135     
- Misses        256      265       +9

Flag	Coverage Δ
unittests	`97.32% <99.09%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/qibocal/protocols/__init__.py	`100.00% <ø> (ø)`
src/qibocal/protocols/readout_mitigation_matrix.py	`97.50% <100.00%> (-2.50%)`	⬇️
...ibocal/protocols/two_qubit_interaction/__init__.py	`100.00% <100.00%> (ø)`
...l/protocols/two_qubit_interaction/chsh/circuits.py	`100.00% <100.00%> (ø)`
...l/protocols/two_qubit_interaction/chsh/protocol.py	`97.66% <100.00%> (ø)`
...protocols/two_qubit_interaction/mermin/__init__.py	`100.00% <100.00%> (ø)`
...protocols/two_qubit_interaction/mermin/protocol.py	`100.00% <100.00%> (ø)`
src/qibocal/protocols/utils.py	`92.22% <100.00%> (+0.02%)`	⬆️
...l/protocols/two_qubit_interaction/mermin/pulses.py	`97.14% <97.14%> (ø)`
...al/protocols/two_qubit_interaction/mermin/utils.py	`96.29% <96.29%> (ø)`

... and 2 files with indirect coverage changes

igres26 · 2024-11-18T13:26:31Z

I am trying to test this. What other branches of Qibo and qibolab should I be using to run this? I cannot get the versions to work on my end.

src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py

igres26 · 2024-11-19T15:59:36Z

src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py

+    figures = []
+    targets = data.targets
+
+    n_targets = len(targets)


Suggested change

n_targets = len(targets)

n_targets = len(targets[0])

Ok, so n_targets = len(target) would be better.

It just has to be the number of qubits involved. Any way we get that it should work.

src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py

igres26 · 2024-11-19T16:43:28Z

@Edoardo-Pedicillo

Together with my proposed changes and @andrea-pasquale's it finally works.

Here are some results for 3 qubit Mermin: http://login.qrccluster.com:9000/bAaPJfD_RCyLslDSTgNkFA==/

And some for 2 qubit Mermin: http://login.qrccluster.com:9000/L-IDUlkmTRSYQp8oW95_GQ==/

Readout error mitigation works weirdly. It seems to invert the results, so it might be easy to fix. This is a result with it enabled: http://login.qrccluster.com:9000/Fp6E5gXxRpqhISPPmWPnmA==/

Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com> Co-authored-by: Sergi Ramos <36544268+igres26@users.noreply.github.com>

for more information, see https://pre-commit.ci

Edoardo-Pedicillo · 2024-11-20T15:02:13Z

Readout error mitigation works weirdly. It seems to invert the results, so it might be easy to fix. This is a result with it enabled: http://login.qrccluster.com:9000/Fp6E5gXxRpqhISPPmWPnmA==/

This is because the zeros are treated as ones and vice versa. The cause of this is the strange shape of the mitigation matrix, where the columns are flipped respect to what it is usually expected.

qibocal/src/qibocal/protocols/readout_mitigation_matrix.py

Line 164 in c8b54f2

matrix[:, int(state, 2)] = np.flip(column)

This should be fixed in #1045

igres26 · 2024-11-20T15:05:29Z

Readout error mitigation works weirdly. It seems to invert the results, so it might be easy to fix. This is a result with it enabled: http://login.qrccluster.com:9000/Fp6E5gXxRpqhISPPmWPnmA==/

This is because the zeros are treated as ones and vice versa. The cause of this is the strange shape of the mitigation matrix, where the columns are flipped respect to what it is usually expected.

qibocal/src/qibocal/protocols/readout_mitigation_matrix.py

Line 164 in c8b54f2

matrix[:, int(state, 2)] = np.flip(column)

This should be fixed in #1045

Then we should be ready to merge.

igres26

With the readout error mitigation fixed in another pull request, this should be ready.

Increase the compatibility between transpiler and chsh

Refactor readout mitigation matrix routine

igres26 · 2024-11-25T09:38:57Z

Did you try to run it? I am getting an error now:

�[38;20m[Qibocal 0.1.1|INFO|2024-11-25 09:18:57]: Finished acquisition in 310.17 seconds�[0m
Traceback (most recent call last):
  File "/nfs/users/sergi.ramos/qiboenv/bin/qq", line 8, in <module>
    sys.exit(command())
  File "/nfs/users/sergi.ramos/qiboenv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/nfs/users/sergi.ramos/qiboenv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/nfs/users/sergi.ramos/qiboenv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/nfs/users/sergi.ramos/qiboenv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/nfs/users/sergi.ramos/qiboenv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/cli/_base.py", line 75, in run
    protocols_execution(runcard, folder, force, update)
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/cli/run.py", line 42, in protocols_execution
    history = runcard.run(
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/auto/runcard.py", line 63, in run
    instance.run_protocol(
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/auto/execute.py", line 131, in run_protocol
    completed = task.run(platform=self.platform, targets=self.targets, mode=mode)
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/auto/task.py", line 169, in run
    completed.results, completed.results_time = operation.fit(completed.data)
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/auto/operation.py", line 42, in wrapper
    out = func(*args, **kwds)
  File "/nfs/users/sergi.ramos/qibocal/src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py", line 153, in _fit
    mitigated_output = np.dot(
ValueError: shapes (8,8) and (1,) not aligned: 8 (dim 1) != 1 (dim 0)

In the error mitigation part.

Edoardo-Pedicillo · 2024-11-28T06:39:49Z

http://login.qrccluster.com:9000/0sPBhijuT5OZMx6U872DfQ==/

DavidSarlle · 2024-11-28T07:39:49Z

@Edoardo-Pedicillo @igres26 I have tried with qblox and IQM chip and it seems to work using qibolab 0.1.
http://login.qrccluster.com:9000/sStJijTvQs6RbovUlHyHVA==

The only thing is that, qblox intruments are connected and disconnected multiple times:

�[38;20m[Qibocal 0.1.1|INFO|2024-11-28 11:27:56]: Executing mode AUTOCALIBRATION on mermin.�[0m
INFO:qibocal.config:Executing mode AUTOCALIBRATION on mermin.
[Qibo 0.2.12|INFO|2024-11-28 11:27:56]: Loading platform /home/users/david.fuentes/qibolab_platforms_qrc/iqm5q
INFO:qibo.config:Loading platform /home/users/david.fuentes/qibolab_platforms_qrc/iqm5q
[Qibo 0.2.12|INFO|2024-11-28 11:27:56]: Using qibolab (/home/users/david.fuentes/qibolab_platforms_qrc/iqm5q) backend on /CPU:0
INFO:qibo.config:Using qibolab (/home/users/david.fuentes/qibolab_platforms_qrc/iqm5q) backend on /CPU:0
[Qibo 0.2.12|INFO|2024-11-28 11:27:56]: Minimal execution time (sequence): 1.236992
INFO:qibo.config:Minimal execution time (sequence): 1.236992
[Qibo 0.2.12|INFO|2024-11-28 11:28:00]: Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: QbloxController: all modules connected.
INFO:qibo.config:QbloxController: all modules connected.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.rohde_schwarz.SGS100A object at 0x77a99e9e5c90>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.rohde_schwarz.SGS100A object at 0x77a99e9e5c90>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f75ed0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f75ed0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f76bc0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f76bc0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5cf0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5cf0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5b70>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5b70>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5840>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5840>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7010>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7010>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7910>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7910>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7fd0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7fd0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7340>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7340>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:09]: Minimal execution time (sequence): 1.2373196800000001
INFO:qibo.config:Minimal execution time (sequence): 1.2373196800000001
[Qibo 0.2.12|INFO|2024-11-28 11:28:13]: Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:21]: QbloxController: all modules connected.
INFO:qibo.config:QbloxController: all modules connected.
[Qibo 0.2.12|INFO|2024-11-28 11:28:21]: Connecting to instrument <qibolab.instruments.rohde_schwarz.SGS100A object at 0x77a99e9e5c90>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.rohde_schwarz.SGS100A object at 0x77a99e9e5c90>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f75ed0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f75ed0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f76bc0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qrm_rf.QrmRf object at 0x77a9a5f76bc0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5cf0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5cf0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5b70>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5b70>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5840>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_rf.QcmRf object at 0x77a99e9e5840>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7010>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7010>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7910>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7910>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7fd0>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7fd0>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7340>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.cluster_qcm_bb.QcmBb object at 0x77a99e9e7340>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:22]: Minimal execution time (sequence): 1.2373196800000001
INFO:qibo.config:Minimal execution time (sequence): 1.2373196800000001
[Qibo 0.2.12|INFO|2024-11-28 11:28:26]: Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
INFO:qibo.config:Connecting to instrument <qibolab.instruments.qblox.controller.QbloxController object at 0x77a99e9e5c60>.
[Qibo 0.2.12|INFO|2024-11-28 11:28:34]: QbloxController: all modules connected.
INFO:qibo.config:QbloxController: all modules connected.

Is it normal??

Edoardo-Pedicillo · 2024-11-28T08:39:27Z

Is it normal??

Yes, because the platform is connected twice in the acquisition: when we evaluate the mitigation matrix, the platform is connected to execute the circuits and disconnected by Qibolab afterwards, so before running the Mermin experiment, we need to reconnect it again.

andrea-pasquale and others added 10 commits March 24, 2024 12:00

feat: Mermin acquisition function

5d1b73a

Merge branch 'main' into mermin

58e7426

fix: Add mermin pulses

b05f7c5

first commit with generalization of mermin - angle and qubits

59e4edb

[pre-commit.ci] auto fixes from pre-commit.com hooks

15c896e

for more information, see https://pre-commit.ci

fixes mermin - not completed

703a0ce

[pre-commit.ci] auto fixes from pre-commit.com hooks

3219031

for more information, see https://pre-commit.ci

refactor: remove mermin with circuits

7bba59b

refactor: clean create_mermin_sequence(s)

e314e48

refactor: define proper data in MerminData

959bb41

Edoardo-Pedicillo added 6 commits November 13, 2024 23:10

refactor: update fit function

04377f9

refactor: define STRING_TYPE

974de63

feat: define targets property

6ff492a

fix: typo in plot function

4511075

refactor docs: update docs and remove circuit mermin

d1bc0da

Merge branch 'main' into mermin_refactor and fix tests

f2e9c34

Edoardo-Pedicillo changed the base branch from mermin-nqubits to main November 14, 2024 12:50

Edoardo-Pedicillo added 3 commits November 14, 2024 16:53

refactor: remove action_qq.yml

4c2e575

fix: fix merging bugs

de1d327

fix: remove try-except and fix lint

75d5097

Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Nov 14, 2024

Edoardo-Pedicillo added 2 commits November 14, 2024 17:11

fix: rename variable

358d15e

fix: evaluate outputs also when mitigation is False

b7039ff

Edoardo-Pedicillo marked this pull request as ready for review November 15, 2024 08:48

Edoardo-Pedicillo requested a review from igres26 November 15, 2024 08:48

igres26 reviewed Nov 19, 2024

View reviewed changes

src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py Outdated Show resolved Hide resolved

igres26 reviewed Nov 19, 2024

View reviewed changes

src/qibocal/protocols/two_qubit_interaction/mermin/protocol.py Outdated Show resolved Hide resolved

Edoardo-Pedicillo and others added 7 commits November 20, 2024 10:16

Apply suggestions from code review

2061ebb

Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com> Co-authored-by: Sergi Ramos <36544268+igres26@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

c8b54f2

for more information, see https://pre-commit.ci

fix: define PADDING constant

4d71606

fix: change n_targets

1c8d9e0

refactor: readout mitigation matrix acquisition and post-processing

87b4ebd

fix: propagate changes in the other routines and fix tests

6cd7e29

fix: remove pickle

f35f166

igres26 approved these changes Nov 20, 2024

View reviewed changes

Edoardo-Pedicillo added 5 commits November 21, 2024 15:39

fix: circuit execution issue

b7a9249

fix: use 2q circuits

a5f5dd0

fix: add check before dumping the mitigation matrix

4c0013a

Merge pull request #1047 from qiboteam/chsh

d7f30da

Increase the compatibility between transpiler and chsh

Merge pull request #1045 from qiboteam/readout_mitigation

5204ba3

Refactor readout mitigation matrix routine

Edoardo-Pedicillo added 2 commits November 25, 2024 19:26

fix: evaluate the state properly

804abff

fix: connect platform after circuit execution

407d537

Edoardo-Pedicillo added this pull request to the merge queue Nov 28, 2024

Merged via the queue into main with commit 1ecda26 Nov 28, 2024
21 checks passed

Edoardo-Pedicillo deleted the mermin_refactor branch November 28, 2024 08:46

Edoardo-Pedicillo mentioned this pull request Nov 28, 2024

Generalizing Mermin to n qubits and adding theta angles for plot #1005

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mermin refactor #1038

Mermin refactor #1038

Edoardo-Pedicillo commented Nov 5, 2024 •

edited

Loading

alecandido commented Nov 6, 2024 •

edited

Loading

Edoardo-Pedicillo commented Nov 6, 2024

Edoardo-Pedicillo commented Nov 13, 2024

codecov bot commented Nov 14, 2024 •

edited

Loading

igres26 commented Nov 18, 2024

igres26 Nov 19, 2024

Edoardo-Pedicillo Nov 20, 2024

igres26 Nov 20, 2024

igres26 commented Nov 19, 2024

Edoardo-Pedicillo commented Nov 20, 2024

igres26 commented Nov 20, 2024

igres26 left a comment

igres26 commented Nov 25, 2024 •

edited

Loading

Edoardo-Pedicillo commented Nov 28, 2024

DavidSarlle commented Nov 28, 2024 •

edited by alecandido

Loading

Edoardo-Pedicillo commented Nov 28, 2024

Mermin refactor #1038

Mermin refactor #1038

Conversation

Edoardo-Pedicillo commented Nov 5, 2024 • edited Loading

alecandido commented Nov 6, 2024 • edited Loading

Edoardo-Pedicillo commented Nov 6, 2024

Edoardo-Pedicillo commented Nov 13, 2024

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

igres26 commented Nov 18, 2024

igres26 Nov 19, 2024

Choose a reason for hiding this comment

Edoardo-Pedicillo Nov 20, 2024

Choose a reason for hiding this comment

igres26 Nov 20, 2024

Choose a reason for hiding this comment

igres26 commented Nov 19, 2024

Edoardo-Pedicillo commented Nov 20, 2024

igres26 commented Nov 20, 2024

igres26 left a comment

Choose a reason for hiding this comment

igres26 commented Nov 25, 2024 • edited Loading

Edoardo-Pedicillo commented Nov 28, 2024

DavidSarlle commented Nov 28, 2024 • edited by alecandido Loading

Edoardo-Pedicillo commented Nov 28, 2024

Edoardo-Pedicillo commented Nov 5, 2024 •

edited

Loading

alecandido commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 14, 2024 •

edited

Loading

igres26 commented Nov 25, 2024 •

edited

Loading

DavidSarlle commented Nov 28, 2024 •

edited by alecandido

Loading