Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional and virtual phase experiment improvements #1066

Merged
merged 6 commits into from
Jan 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
get rid of argument amplitude, and rename argument duration to flux_p…
…ulse_max_duration
hay-k committed Jan 9, 2025
commit 1e307e1add635251d268a467fcadb83c62205c1a
12 changes: 5 additions & 7 deletions src/qibocal/protocols/two_qubit_interaction/virtual_z_phases.py
Original file line number Diff line number Diff line change
@@ -98,8 +98,7 @@ def create_sequence(
native: str,
parking: bool,
dt: float,
amplitude: float = None,
duration: float = None,
flux_pulse_max_duration: float = None,
) -> tuple[
PulseSequence,
dict[QubitId, Pulse],
@@ -118,11 +117,10 @@ def create_sequence(
start=max(Y90_pulse.finish, RX_pulse_start.finish),
)

if amplitude is not None:
flux_sequence.get_qubit_pulses(ordered_pair[1])[0].amplitude = amplitude

if duration is not None:
flux_sequence.get_qubit_pulses(ordered_pair[1])[0].duration = duration
if flux_pulse_max_duration is not None:
flux_sequence.get_qubit_pulses(ordered_pair[1])[
0
].duration = flux_pulse_max_duration
theta_pulse = platform.create_RX90_pulse(
target_qubit,
start=flux_sequence.finish + dt,