-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling global backend for protocols involving circuits #1076
Changes from 9 commits
cf08f45
8c52ce5
53ba1be
713956b
a86f91d
8ea8342
b7195db
9edcba8
7c5aed5
61039a9
59f95e3
d519948
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -4,6 +4,10 @@ | |||
import pytest | ||||
|
||||
|
||||
def pytest_configure(): | ||||
os.environ["QIBO_PLATFORM"] = "dummy" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we are avoiding the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are some tests which are specifically looking at this env variable: qibocal/tests/test_executor.py Line 179 in bc7a7ba
I noticed it because when I wan running tests on the cluster they were trying to connect to QM. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, my bad. I introduced that test when I implemented the scripting mechanism, because that was the context at the time. However, there is no special reason to keep it, so you could just drop the test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid trigerring the error we can also decide to not rely on |
||||
|
||||
|
||||
@pytest.fixture(autouse=True) | ||||
def cd(tmp_path_factory: pytest.TempdirFactory): | ||||
path: Path = tmp_path_factory.mktemp("run") | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle here you could add something like
to retain the previous behavior when the backend is not qibolab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep assuming it is Qibolab, to make everything simpler. Even though in some places may be simpler to deal with other backends, it may fail in other places. We will overhaul this consistently later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the expected behavior would be to have a qibolab platform
qibocal/src/qibocal/cli/run.py
Lines 22 to 23 in 59f95e3