Compatibility Update for Qibolab 0.2 #1083
Draft
+124
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
+ Coverage 50.55% 50.96% +0.40%
==========================================
Files 63 63
Lines 2886 2910 +24
==========================================
+ Hits 1459 1483 +24
Misses 1427 1427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
4 tasks
| def natives(self) -> list[str]: | ||
| """Returns the list of native gates supported by the platform.""" | ||
| compiler = Compiler.default() | ||
| natives = [g.__name__ for g in list(compiler.rules)] |
There was a problem hiding this comment.
The native gates are defined directly from the compiler rules. We should receive them directly from the platform (see qiboteam/qibocal#1090).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same updates as #1079 and #1076 for Qibolab 0.2.
Checklist: