Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mypy check in CI #221

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Mar 11, 2025

Summary

Currently CI is failing mypy checks, It seems this happens with the latest numpy version (2.2.x and above) that has changed things
I chose to simply disable the mypy checks for now as there are many errors that would need sorting to keep mypy checks in place. It would be possible to limit numpy in CI here to < 2.2, where it still passes fine, but I chose instead to have the latest numpy installed so its unit tested with that.

Details and comments

See #218 (comment) for more information.

I created #222 as a reminder this has been done so potentially mypy checks can be re-instated at some future point.

#74 also talks about type improvements


I see now CI is failing with 3.8 where its trying to build a wheel for qiskit-aer. As Python 3.8 reached EOL in October 2024 and is no longer maintained I am removing it as a supported version and hence from CI. I added an upgrade release note accordingly.

closes #201

Note: I have not updated the branch protection rules, which include CI runs done on 3.8, so for now CI will still show these as required but they will not be run. If this is all ok I will update the rules.

Note: while this is adjusting supported Python versions it is only doing so as CI is failing on 3.8 and this PR is to get CI running again. Hence while it could be adjusted more, ie add 3.13 assuming it passes tests. I think that's better done in a separate PR.

@woodsp-ibm
Copy link
Member Author

I added october to custom dictionary as it failed spell check

<reno.sphinxext current branch>:29: : Spell check: october: in October 2024 and is no longer being maintained. If you were.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13794434754

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.474%

Totals Coverage Status
Change from base Build 12209091052: 0.04%
Covered Lines: 6392
Relevant Lines: 7065

💛 - Coveralls

@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented Mar 11, 2025

The CI tasks,, which run against (monitor) Qiskit main branch to ensure it continues to work for new releases is failing. This is due to algorithms still using V1 primitives. I imagine that once that is released things will fail here - a pin for Qiskit < 2.0 could be added now, which would avoid that preemptively. I guess that can be done in a separate PR too, like adding 3.13 Python support as noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.9 is now Qiskit minimum level supported
2 participants