Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6 release notes and deprecation policy #1385
0.6 release notes and deprecation policy #1385
Changes from 5 commits
f99b279
12f9d25
8de4e04
f12c50c
db331c6
112f1e9
22812bc
afeeb81
b9fb13e
b817048
d720f6d
6d993f6
79f9265
553f502
931d05d
b57deb0
2cf403c
280bc1a
6641efa
5544899
5df6090
8edbd46
0d62d21
bfce4f1
e1ed9fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wshanks I'm linking to the commit where
DEPRECATION.md
was added to Qiskit. Not sure if there's a better link.What do you think about this timeline? It's faster than the Qiskit policy, which says the old feature cannot be removed in the minor release immediately after the warnings, but that would be far too long for us. The other thing is we don't use
PendingDeprecationWarning
that much right now, and it creates more code churn than just starting with aDeprecationWarning
and keeping that for two cycles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link seems okay. A cleaner link might be the rc1 tag: https://github.com/Qiskit/qiskit/blob/1.0.0rc1/DEPRECATION.md That's a little misleading if the file gets changed before 1.0.0, but the file isn't in the 0.46 release branch. It could probably be backported.
Three cycles seems like too much for this package. I like the pending deprecation warnings, but they may be too much overhead for us to manage right now. Perhaps we could use deprecation helper functions that check the current version and automatically determine the warning type by comparing to the
since
argument. The goal with pending is to give downstream libraries a chance to test for and fix pending deprecations before they become deprecations since those print out to users. I don't know that we have many downstream consumers that are not end users. It makes most sense for library consumers in between the package emitting the warning and end users.We have also discussed reducing the deprecation cycle to a single version for features outside of the framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated the link. I broke the changes into three types in 553f502 and made specifying pending warnings optional.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.