Cleanup composite analysis #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshanks
added
the
backport stable potential
coruscating
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Thanks @nkanazawa1989, the new code is much cleaner. I only have a comment regarding a bug not from this PR.
| ) | ||
| ) | ||
|
|
||
| if self.options.return_data_points: |
There was a problem hiding this comment.
Ah, I found a bug while testing this, return_data_points=True throws an error right now because it's trying to use the old groupby syntax with ScatterTable.
I think the fix is
https://github.com/Qiskit-Extensions/qiskit-experiments/blob/0bbd426dc257be6d35daf04d94bbb31e0d059648/qiskit_experiments/curve_analysis/base_curve_analysis.py#L356
should be curve_data.dataframe.groupby("series_name"))
There was a problem hiding this comment.
Thanks for catching the bug!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
### Summary Thanks to #1342 we can cleanup internals of `CompositeCurveAnalysis`. Not API break and no feature upgrade with this PR. ### Details and comments Previously the curve data and fit summary data are internally created in `CurveAnalysis` but immediately discarded. The implementation in `CurveAnalysis._run_analysis` is manually copied to `CompositeCurveAnalysis._run_analysis` to access these artifact data to create composite artifact data from them. This makes code fragile since developers needed to manually update both base classes. With this PR, implementation of component analysis is encapsulated. (cherry picked from commit cb37d42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to #1342 we can cleanup internals of
CompositeCurveAnalysis. Not API break and no feature upgrade with this PR.Details and comments
Previously the curve data and fit summary data are internally created in
CurveAnalysisbut immediately discarded. The implementation inCurveAnalysis._run_analysisis manually copied toCompositeCurveAnalysis._run_analysisto access these artifact data to create composite artifact data from them. This makes code fragile since developers needed to manually update both base classes. With this PR, implementation of component analysis is encapsulated.