-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file_delete method to delete experiment file #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Qiskit Experiments and this works! Just some minor comments.
def file_delete(self, experiment_id: str, file_pathname: str): | ||
"""Deletes a data file from the DB | ||
Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this note will render correctly, you'll want to use .. note::
(consult the sphinx rst primer). You can build the docs locally with tox -edocs
and preview them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you test this? I actually don't see file_delete()
in the built docs from the latest run:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local qiskit_ibm_experiment
module is not accessible to sphinx, so it uses the existing pip module, which doesn't have the file_delete
method.
When I add the path of the local qiskit_ibm_experiment
to PYTHONPATH
, sphinx builds the documentations for the new methods.
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
Implemented
file_delete
service function to delete an artifact file of an experiment.