Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file_delete method to delete experiment file #101

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Add file_delete method to delete experiment file #101

merged 6 commits into from
Jul 22, 2024

Conversation

1d4n
Copy link
Collaborator

@1d4n 1d4n commented Mar 21, 2024

Implemented file_delete service function to delete an artifact file of an experiment.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@1d4n 1d4n marked this pull request as draft March 21, 2024 13:43
@1d4n 1d4n changed the title [WIP] Add file_delete method to delete experiment file Add file_delete method to delete experiment file Mar 28, 2024
@1d4n 1d4n marked this pull request as ready for review March 28, 2024 11:47
Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Qiskit Experiments and this works! Just some minor comments.

def file_delete(self, experiment_id: str, file_pathname: str):
"""Deletes a data file from the DB
Note:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this note will render correctly, you'll want to use .. note:: (consult the sphinx rst primer). You can build the docs locally with tox -edocs and preview them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this? I actually don't see file_delete() in the built docs from the latest run:
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local qiskit_ibm_experiment module is not accessible to sphinx, so it uses the existing pip module, which doesn't have the file_delete method.
When I add the path of the local qiskit_ibm_experiment to PYTHONPATH , sphinx builds the documentations for the new methods.

1d4n and others added 3 commits April 18, 2024 11:26

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@1d4n 1d4n merged commit da7d5b4 into qiskit-community:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants