Simpler bloch redfield tensor #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into simpler-bloch-redfield-tensor
…into simpler-bloch-redfield-tensor
…109/QuantumOptics.jl into simpler-bloch-redfield-tensor
…109/QuantumOptics.jl into simpler-bloch-redfield-tensor
|
I've just noticed the new PR #306 which also makes some changes to the bloch_redfield_tensor function. None of the changes look like they conflict with each other, but will need to double check before merging this. |
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 98.08% 97.98% -0.11%
==========================================
Files 15 15
Lines 1305 1288 -17
==========================================
- Hits 1280 1262 -18
- Misses 25 26 +1
Continue to review full report at Codecov.
|
|
Yeah this is ready to merge as far as I'm concerned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves both efficiency and readability of Bloch-Redfield tensor implementation. Also utilizes multi-threading when julia session is running with more than one thread available. I'd say this probably closes #270 too.