Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function correlation_dynamic #325

Merged
merged 5 commits into from
Feb 11, 2022
Merged

Conversation

zejian-li
Copy link
Contributor

Add function for computing two-time correlations for time-dependent master equation.

Add function for computing two-time correlations for time-dependent master equation.
@ChristophHotter
Copy link
Member

ChristophHotter commented Jan 26, 2022

Seems okay for me.
@zejian-li Could you please also add a test to the file test_timecorrelations.jl?

Same test as for timecorrelations.correlation but in a rotating frame for the cavity mode, which does not affect the correlation for spin operators.
in order for test_timecorrelations to call timecorrelations.correlation_dynamic
@zejian-li
Copy link
Contributor Author

Seems okay for me. @zejian-li Could you please also add a test to the file test_timecorrelations.jl?

Ok I haved added some tests based on the the existing ones for timecorrelations.correlation and verified locally that they would pass.

…cstring

Co-authored-by: Filippo Vicentini <filippovicentini@gmail.com>
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #325 (0993ebb) into master (3d0499c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   98.24%   98.27%   +0.02%     
==========================================
  Files          16       16              
  Lines        1310     1331      +21     
==========================================
+ Hits         1287     1308      +21     
  Misses         23       23              
Impacted Files Coverage Δ
src/timecorrelations.jl 100.00% <100.00%> (ø)
src/mcwf.jl 100.00% <0.00%> (ø)
src/master.jl 100.00% <0.00%> (ø)
src/timeevolution_base.jl 100.00% <0.00%> (ø)
src/stochastic_schroedinger.jl 100.00% <0.00%> (ø)
src/stochastic_master.jl 97.26% <0.00%> (+0.07%) ⬆️
src/bloch_redfield_master.jl 93.50% <0.00%> (+0.08%) ⬆️
src/semiclassical.jl 96.84% <0.00%> (+0.10%) ⬆️
src/schroedinger.jl 89.65% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0499c...0993ebb. Read the comment docs.

@ChristophHotter ChristophHotter merged commit a605ede into qojulia:master Feb 11, 2022
@ChristophHotter
Copy link
Member

correlation_dynamic() is now in the master branch.
It is available in version 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants