Outsourcing the Gherkin parsing #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delegating the parsing of feature files to the 'cuke_modeler' gem instead of trying to parse them ourselves.
Got most of the tests for comments passing again. Some unsupported behavior will need rethinking.
Removing Gemfile.lock from source control so that it can be rebuilt as needed.
Conditionalizing more gem dependencies so that the project can be tested across multiple version of Ruby.
|
#107 should get this passing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR delegates the burden of parsing feature files to the gherkin gem (via the cuke_modeler gem as an abstraction layer).
Benefits:
Drawbacks:
In any case, because it's a rather significant change, I'm not holding my breath on this PR ever getting accepted. But it's something to think about.