Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax numpy requirement and support numpy 2.0.0 #133

Merged
merged 5 commits into from
Jun 29, 2024
Merged

relax numpy requirement and support numpy 2.0.0 #133

merged 5 commits into from
Jun 29, 2024

Conversation

r9y9
Copy link
Owner

@r9y9 r9y9 commented Jun 29, 2024

No description provided.

@r9y9 r9y9 self-assigned this Jun 29, 2024
r9y9 added 2 commits June 29, 2024 14:07
pyworld's bindary distribution does not support numpy 2.0.0. so runtime
errors will happen on windows if numpy 2.0.0 is used

workaaround this issue by skipping the tests using pyworld
@r9y9
Copy link
Owner Author

r9y9 commented Jun 29, 2024

@r9y9 r9y9 force-pushed the np2 branch 2 times, most recently from 248ea8c to cdf8ec0 Compare June 29, 2024 06:01
@r9y9 r9y9 merged commit 928ff6f into master Jun 29, 2024
6 checks passed
@r9y9 r9y9 deleted the np2 branch June 29, 2024 06:13
@r9y9 r9y9 mentioned this pull request Jun 29, 2024
@r9y9
Copy link
Owner Author

r9y9 commented Jun 29, 2024

fixes for numpy 2.0.0 are indeed #132, which removed unnecessary cython module that was affected by numpy 2.0.0 breaking changes. Everything else was fine with both numpy 1 and 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant