fix: crash undefined deb/rpm main source

When the main archive is not defined (ie. not provided in build request
and source not defined in YAML artifact definition file) on Deb or RPM
package build, Fatbuildr now reports a task execution error instead of
crashing.

Fix #119

Author: rezib

CHANGELOG.md

@@ -43,6 +43,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix unusable version.dist variable in packaging code templates (#116).
 - Fix crash on build on unsupported derivative in instance pipelines (#117).
 - Fix crash on retrieving derivative version in artifact definition (#118).
+- Fix crash when main archive source is not defined on build of Deb or RPM
+  package (#119).
 
 ## [2.0.0] - 2023-05-05
 

fatbuildr/builds/formats/deb.py

@@ -23,6 +23,7 @@
 
 from .. import ArtifactEnvBuild
 from ...utils import current_user, extract_artifact_sources_archives
+from ...errors import FatbuildrTaskExecutionError
 from ...log import logr
 
 logger = logr(__name__)
@@ -98,6 +99,12 @@ def _build_src(self):
             self.artifact,
         )
 
+        if self.main_archive is None:
+            raise FatbuildrTaskExecutionError(
+                f"Main archive of deb package artifact {self.artifact} is not "
+                "defined"
+            )
+
         # Deb source packages do not support source archives in zip format, then
         # first convert all source archives in zip format to tarballs.
         for archive in self.archives:

fatbuildr/builds/formats/rpm.py

@@ -23,6 +23,7 @@
 from ...registry.formats import ChangelogEntry
 from ...templates import Templeter
 from ...utils import current_user, current_group
+from ...errors import FatbuildrTaskExecutionError
 from ...log import logr
 
 logger = logr(__name__)
@@ -166,6 +167,12 @@ def _build_src(self):
             self.native_env,
         )
 
+        if self.main_archive is None:
+            raise FatbuildrTaskExecutionError(
+                f"Main archive of rpm package artifact {self.artifact} is not "
+                "defined"
+            )
+
         # Initialize templater
         templater = Templeter()
 

fatbuildr/errors.py

@@ -22,6 +22,10 @@ class FatbuildrRuntimeError(Exception):
     pass
 
 
+class FatbuildrTaskExecutionError(FatbuildrRuntimeError):
+    pass
+
+
 class FatbuildrServerError(Exception):
     pass
 

fatbuildr/tasks/manager.py

@@ -23,6 +23,7 @@
 import shutil
 from collections import deque
 
+from ..errors import FatbuildrTaskExecutionError
 from ..log import logr
 from ..protocols.exports import ProtocolRegistry
 
@@ -175,7 +176,7 @@ def run(self, task):
         task.prerun()
         try:
             task.run()
-        except RuntimeError as err:
+        except (FatbuildrTaskExecutionError, RuntimeError) as err:
             logger.error("error while running task %s: %s", task.id, err)
             logger.info("Task failed")
         else: