Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when deb or rpm main archive source is not defined #119

Closed
rezib opened this issue Jun 8, 2023 · 0 comments
Closed

Crash when deb or rpm main archive source is not defined #119

rezib opened this issue Jun 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rezib
Copy link
Contributor

rezib commented Jun 8, 2023

When the source of a deb package is not provided in build request and not defined in artifact meta definition, fatbuildrd crashes with the following error:

fatbuildrd[614542]: worker-default: [INFO] fatbuildr.builds.formats.deb Building source Deb packages for slurm
fatbuildrd[614542]: Exception in thread worker-default:
fatbuildrd[614542]: Traceback (most recent call last):
fatbuildrd[614542]:   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
fatbuildrd[614542]:     self.run()
fatbuildrd[614542]:   File "/usr/lib/python3.10/threading.py", line 953, in run
fatbuildrd[614542]:     self._target(*self._args, **self._kwargs)
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/cli/fatbuildrd.py", line 133, in _worker
fatbuildrd[614542]:     instance.tasks_mgr.run(task)
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/tasks/manager.py", line 177, in run
fatbuildrd[614542]:     task.run()
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/builds/__init__.py", line 226, in run
fatbuildrd[614542]:     self.build()
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/builds/formats/deb.py", line 89, in build
fatbuildrd[614542]:     self._build_src()
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/builds/formats/deb.py", line 110, in _build_src
fatbuildrd[614542]:     main_tarball_subdir = extract_artifact_sources_archives(
fatbuildrd[614542]:   File "/usr/lib/python3/dist-packages/fatbuildr/utils.py", line 94, in extract_artifact_sources_archives
fatbuildrd[614542]:     main_archive.path,
fatbuildrd[614542]: AttributeError: 'NoneType' object has no attribute 'path'
@rezib rezib added the bug Something isn't working label Jun 8, 2023
@rezib rezib added this to the v2.1.0 milestone Jun 8, 2023
@rezib rezib self-assigned this Jun 8, 2023
@rezib rezib closed this as completed in c81f2c4 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant