Compiler warnings with binary wrappers

[rezib]

The compiler raises warning when builder the binary wrappers, for example during build on fedora 37:

…
gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -o u-nspawn u-nspawn.c
u-nspawn.c: In function 'main':
u-nspawn.c:38:9: warning: ignoring return value of 'setuid' declared with attribute 'warn_unused_result' [-Wunused-result]
   38 |         setuid(0);
      |         ^~~~~~~~~
u-nspawn.c:39:9: warning: ignoring return value of 'setgid' declared with attribute 'warn_unused_result' [-Wunused-result]
   39 |         setgid(0);
      |         ^~~~~~~~~
sed -e 's|#BIN#|/usr/bin/mkosi|' u-bin.c.in > u-mkosi.c
gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -o u-mkosi u-mkosi.c
u-mkosi.c: In function 'main':
u-mkosi.c:38:9: warning: ignoring return value of 'setuid' declared with attribute 'warn_unused_result' [-Wunused-result]
   38 |         setuid(0);
      |         ^~~~~~~~~
u-mkosi.c:39:9: warning: ignoring return value of 'setgid' declared with attribute 'warn_unused_result' [-Wunused-result]
   39 |         setgid(0);
      |         ^~~~~~~~~
make: Leaving directory '/builddir/build/BUILD/fatbuildr_1.0.1~rc11/lib/wrappers'

This should be fixed.

[Vedant-code]

To fix the issue, you should check the return value of 'setuid' and 'setgid' and handle any errors appropriately.
If you don't care about the return value, you can cast it to (void) to explicitly indicate that you are intentionally ignoring the return value:

(void)setuid(0);
(void)setgid(0);

[rezib]

To fix the issue, you should check the return value of 'setuid' and 'setgid' and handle any errors appropriately. If you don't care about the return value, you can cast it to (void) to explicitly indicate that you are intentionally ignoring the return value:

(void)setuid(0);
(void)setgid(0);

Thank you @Vedant-code for the suggestion!

[Vedant-code]

👍👍

…

On Sat, 11 Mar 2023, 1:50 am Rémi Palancher, ***@***.***> wrote: To fix the issue, you should check the return value of 'setuid' and 'setgid' and handle any errors appropriately. If you don't care about the return value, you can cast it to (void) to explicitly indicate that you are intentionally ignoring the return value: (void)setuid(0); (void)setgid(0); Thank you @Vedant-code <https://github.com/Vedant-code> for the suggestion! — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUJ5TJYQHWK7FLNS7WFE4SDW3OEINANCNFSM6AAAAAAVWTHFQE> . You are receiving this because you were mentioned.Message ID: ***@***.***>