Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required version of boto3 is now ^1.34.50, remove dev dependencies from main group #2499

Merged
merged 15 commits into from
Aug 14, 2024

Conversation

ITProKyle
Copy link
Collaborator

@ITProKyle ITProKyle commented Aug 12, 2024

Summary

Removed dev dependencies from the main dependency group.
Upgrade required version of boto3

Why This Is Needed

  • dependencies that are not needed to run runway are being installed for users for runway
  • the version requirement for boto3 causes slow dependency resolution due to the large number of possible combinations of boto3 and botocore
    • both packages a release every day or few days

What Changed

Changed

  • upgraded required version of boto3 from ^1.16 to ^1.34.50 (a number of patch releases behind the latest version)
  • further split dependencies into different groups
  • upgraded version requirements for dependencies not in the main group
  • extended excepted branch names in the Enforce Branch Name job and updated the autolabel config to include these branch prefixes

Removed

  • removed moto from the main dependency group
  • removed pyinstaller from the main dependency group
  • removed testfixtures from the main dependency group
  • removed wheel from the main dependency group
  • removed urllib3 from main dependency group as it is not a direct dependency

@ITProKyle ITProKyle added dependencies Pull request that updates a dependency file changelog:patch Patch change resulting in a patch release labels Aug 12, 2024
@ITProKyle ITProKyle self-assigned this Aug 12, 2024
@github-actions github-actions bot added github_actions Update to GitHub Actions maintenance General repo or CI/CD upkeep poetry Update to Poetry configuration python Update to Python code labels Aug 12, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (9677b7a) to head (c1b7d63).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2499   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         247      247           
  Lines       15610    15610           
=======================================
  Hits        14073    14073           
  Misses       1537     1537           
Files Coverage Δ
runway/cfngin/hooks/awslambda/models/args.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/_login.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/data_models.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_build.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_push.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_remove.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/ecs.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/ssm/parameter.py 100.00% <100.00%> (ø)
runway/cfngin/lookups/handlers/ami.py 100.00% <100.00%> (ø)
runway/cfngin/lookups/handlers/file.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9677b7a...c1b7d63. Read the comment docs.

attrs
babel
botocore-stubs
bracex
cffi
filelock
identify
jsonpatch
jsonpickle
jsonpointer
jsonschema
markupsafe
mypy-boto3-acm
mypy-boto3-cloudformation
mypy-boto3-cloudfront
mypy-boto3-cognito-idp
mypy-boto3-dynamodb
mypy-boto3-ec2
mypy-boto3-ecr
mypy-boto3-ecs
mypy-boto3-iam
mypy-boto3-kms
mypy-boto3-lambda
mypy-boto3-route53
mypy-boto3-s3
mypy-boto3-ssm
nodeenv
pywin32
pyyaml
regex
responses
s3transfer
termcolor
types-s3transfer
wcmatch
distlib
pathspec
pbr
platformdirs
pygments
troposphere
virtualenv
pathspec
pbr
pygments
troposphere
@ITProKyle
Copy link
Collaborator Author

Through process of elimination, updating the following set of dependencies in poetry.lock causes the pipenv tests to fail on Windows:

distlib
platformdirs
virtualenv

Copy link

@alexander-kogan alexander-kogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ITProKyle ITProKyle merged commit 26e72a7 into master Aug 14, 2024
31 checks passed
@ITProKyle ITProKyle deleted the maint/cleanup branch August 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:patch Patch change resulting in a patch release dependencies Pull request that updates a dependency file github_actions Update to GitHub Actions maintenance General repo or CI/CD upkeep poetry Update to Poetry configuration python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants