add IP change listener to getVerifiedLocationToken() #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpatrick
commented
Dec 15, 2024
| @@ -109,31 +108,9 @@ class TrackAPI { | |||
| }, | |||
| }); | |||
|
|
|||
| let sclVal = -1; | |||
There was a problem hiding this comment.
Remove old ping call
nickpatrick
commented
Dec 15, 2024
src/api/verify.ts
Outdated
|
|
||
| class VerifyAPI { | ||
| static async ipChanged() { |
There was a problem hiding this comment.
Calls GET /v1/ping, returns true if IP changed
There was a problem hiding this comment.
nit: would call this function checkIPChange
Also, should this function only fire if lastIp is set? otherwise it will always trigger a change
nickpatrick
commented
Dec 15, 2024
| let { interval } = params; | ||
| if (!interval) { | ||
| interval = 60; | ||
| Logger.info(`interval not provided, using 60 seconds`); |
There was a problem hiding this comment.
Adds default interval of 60 seconds, avoids bug if interval undefined
nickpatrick
commented
Dec 15, 2024
src/api/verify.ts
Outdated
| ipChanged = await this.ipChanged(); | ||
| } | ||
|
|
||
| if (lastToken && lastToken.passed && !ipChanged) { |
There was a problem hiding this comment.
Requests new token if IP changed
nickpatrick
commented
Dec 15, 2024
| @@ -96,7 +96,7 @@ class RadarMap extends maplibregl.Map { | |||
| radarMapOptions, | |||
| { style }, | |||
| ); | |||
| Logger.debug('map initailized with options', mapOptions); | |||
| Logger.debug('map initialized with options', mapOptions); | |||
nickpatrick
commented
Dec 15, 2024
| @@ -104,6 +121,11 @@ class VerifyAPI { | |||
| } | |||
| } | |||
|
|
|||
| if (params.ipChanges && trackRes?.user?.ip) { | |||
There was a problem hiding this comment.
Also picks up IP changes in trackVerified() responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.