Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE ME] Split Sargon into many crates #318

Merged
merged 14 commits into from
Jan 8, 2025

Split Sargon-OS crate (#332)

16162d6
Select commit
Loading
Failed to load commit list.
Merged

[MERGE ME] Split Sargon into many crates #318

Split Sargon-OS crate (#332)
16162d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 7, 2025 in 1s

92.2% (-1.1%) compared to e18bd66

View this Pull Request on Codecov

92.2% (-1.1%) compared to e18bd66

Details

Codecov Report

Attention: Patch coverage is 82.56684% with 163 lines in your changes missing coverage. Please review.

Project coverage is 92.2%. Comparing base (e18bd66) to head (16162d6).

Files with missing lines Patch % Lines
.../app/signing/src/collector/signatures_collector.rs 82.8% 42 Missing ⚠️
...wiftified/Profile/Factor/FactorSource+Extras.swift 0.0% 27 Missing ⚠️
...file/Factor/FactorSourceIntegrity+Swiftified.swift 0.0% 24 Missing ⚠️
...es/core/has-sample-values/src/has_sample_values.rs 33.3% 16 Missing ⚠️
crates/app/radix-connect/src/mobile/client.rs 80.2% 14 Missing ⚠️
...dix-connect/src/mobile/deep_link_parsing/parser.rs 74.0% 14 Missing ⚠️
crates/common/bytes/src/secret_bytes.rs 76.9% 6 Missing ⚠️
...ctor_of_instances_required_to_sign_transactions.rs 70.5% 5 Missing ⚠️
...o_dapp/success_response/transaction/transaction.rs 80.9% 4 Missing ⚠️
...wiftified/Profile/Account/Account+Swiftified.swift 0.0% 3 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #318     +/-   ##
=======================================
- Coverage   93.3%   92.2%   -1.1%     
=======================================
  Files       1111    1143     +32     
  Lines      24248   25773   +1525     
  Branches      79      79             
=======================================
+ Hits       22637   23779   +1142     
- Misses      1596    1979    +383     
  Partials      15      15
Files with missing lines Coverage Δ
...thods/Profile/CAP26EntityKind+Wrap+Functions.swift 100.0% <100.0%> (ø)
...ied/Crypto/Derivation/AccountPath+Swiftified.swift 100.0% <100.0%> (ø)
...ed/Crypto/Derivation/IdentityPath+Swiftified.swift 100.0% <100.0%> (ø)
...wiftified/Profile/CAP26EntityKind+Swiftified.swift 100.0% <100.0%> (ø)
...rc/deferred_deep_link/deferred_deep_link_method.rs 100.0% <ø> (ø)
...c/deferred_deep_link/onboarding_deep_link_value.rs 100.0% <ø> (ø)
crates/app/home-cards/src/home_card.rs 100.0% <ø> (ø)
crates/app/home-cards/src/home_cards.rs 100.0% <100.0%> (ø)
crates/app/home-cards/src/manager.rs 81.8% <ø> (ø)
...p/radix-connect-models/src/auth_challenge_nonce.rs 100.0% <ø> (ø)
... and 131 more

... and 1158 files with indirect coverage changes

View more details on Codecov