Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Factors module into separate crate (and some more) #324

Merged
merged 48 commits into from
Dec 30, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Dec 29, 2024

Note

Target branch is not main

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.1%. Comparing base (42f3b01) to head (7178fe5).
Report is 1 commits behind head on ac/split.

Files with missing lines Patch % Lines
.../test_keys_collector/test_derivation_interactor.rs 87.5% 3 Missing ⚠️
crates/sargon-core/src/has_sample_values.rs 83.3% 2 Missing ⚠️
...argon-factors/src/factor_source_id_from_address.rs 75.0% 2 Missing ⚠️
...argon/src/types/samples/account_address_samples.rs 50.0% 1 Missing ⚠️
...rgon/src/types/samples/identity_address_samples.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           ac/split    #324     +/-   ##
==========================================
- Coverage      93.2%   93.1%   -0.1%     
==========================================
  Files          1116    1122      +6     
  Lines         24375   24781    +406     
  Branches         79      79             
==========================================
+ Hits          22726   23091    +365     
- Misses         1634    1675     +41     
  Partials         15      15             
Flag Coverage Δ
kotlin 97.1% <ø> (ø)
rust 92.6% <94.4%> (-0.1%) ⬇️
swift 94.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-vec-of/src/decl_identified_vec_of_with_samples.rs 100.0% <ø> (ø)
crates/identified-vec-of/src/identified_vec_of.rs 86.6% <ø> (ø)
...fied-vec-of/src/identified_vec_of_display_debug.rs 100.0% <ø> (ø)
...dentified-vec-of/src/identified_vec_of_iterator.rs 100.0% <ø> (ø)
.../identified-vec-of/src/identified_vec_of_modify.rs 86.6% <ø> (ø)
...s/identified-vec-of/src/identified_vec_of_query.rs 100.0% <ø> (ø)
...s/identified-vec-of/src/identified_vec_of_serde.rs 85.7% <ø> (ø)
.../src/identified_vec_of_validation_import_export.rs 100.0% <100.0%> (ø)
...addresses/src/address/access_controller_address.rs 100.0% <ø> (ø)
...es/sargon-addresses/src/address/account_address.rs 73.6% <100.0%> (ø)
... and 152 more

@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review December 30, 2024 07:37
@CyonAlexRDX CyonAlexRDX changed the title Ac/split 03 factors Split Factors module into separate crate (and some more) Dec 30, 2024
Base automatically changed from ac/split-hd to ac/split December 30, 2024 08:25
Sajjon and others added 2 commits December 30, 2024 09:48
Split out module `Addresses` & `KeysCollector` into new crates
@CyonAlexRDX CyonAlexRDX merged commit 81aef4b into ac/split Dec 30, 2024
10 of 11 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ac/split-03-factors branch December 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants