Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new device factor source #380

Merged
merged 33 commits into from
Feb 21, 2025

Improve API

7e9c279
Select commit
Loading
Failed to load commit list.
Merged

Adding new device factor source #380

Improve API
7e9c279
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2025 in 1s

92.56% (-0.01%) compared to 4576ccc, passed because coverage increased by 0% when compared to adjusted base (92.55%)

View this Pull Request on Codecov

92.56% (-0.01%) compared to 4576ccc, passed because coverage increased by 0% when compared to adjusted base (92.55%)

Details

Codecov Report

Attention: Patch coverage is 89.93289% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (4576ccc) to head (7e9c279).

Files with missing lines Patch % Lines
...on_os/add_factor_source/device_mnemonic_builder.rs 0.00% 6 Missing ⚠️
crates/factors/factors/src/factor_source.rs 84.00% 4 Missing ⚠️
.../uniffi_SPLIT_ME/src/core/utils/builder_arc_map.rs 0.00% 3 Missing ⚠️
...add_factor_source/sargon_os_factor_source_adder.rs 94.59% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   92.56%   92.56%   -0.01%     
==========================================
  Files        1227     1230       +3     
  Lines       28348    28495     +147     
  Branches       85       85              
==========================================
+ Hits        26239    26375     +136     
- Misses       2098     2109      +11     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov