-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Modify manifests based on Security State / Fee Payer / Guarantees #384
Draft
micbakos-rdx
wants to merge
16
commits into
main
Choose a base branch
from
mib/ABW-4164-modify-tx-manifest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
88c1873
to
c6016f4
Compare
825bd75
to
b4535f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR is still in early WIP
I am publishing it just to share the progress so far and keep track of some significant changes that need to happen. One example is the need, IMHO, to hoist the modifying of the manifests to sargon os. Currently this responsibility is in hosts and does not involve the state of the profile.
I will type in a full description of the summary of the work, when I will finalise the design. For now I am going to keep track of the changes:
Significant changes
manifests
crate I needed to define some traits with common properties with different versions of manifests, instructions and builders. Thus I created theIntoManifest
,IntoInstruction
andIntoManifestBuilder
traits which can be used when modifying any kind of manifest. These traits arepub(crate)
since they are only useful to this crate which has to do with manifests and modifying them.StaticallyAnalyzableManifest
andDynamicallyAnalyzableManifest
intomanifests
crate. The reason for that is that modifying the manifests we are about to analyze, requires the dependency intomanifests
frommanifest-models
. This is impossible due to cyclic dependencies.