Fork/rafek1241/feature/add azure event hubs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/add-azure-event-hubs
…ture/add-azure-event-hubs
… into fork/rafek1241/feature/add-azure-event-hubs
rafek1241
reviewed
Feb 5, 2025
| properties.Add("UseDevelopmentEmulator", UseDevelopmentEmulator); | ||
| properties.Add("SharedAccessKeyName", "RootManageSharedAccessKey"); | ||
| properties.Add("SharedAccessKey", "SAS_KEY_VALUE"); | ||
| properties.Add("UseDevelopmentEmulator", "true"); | ||
| return string.Join(";", properties.Select(property => string.Join("=", property.Key, property.Value))); |
There was a problem hiding this comment.
Why are you not using const strings for hardcoded values?
There was a problem hiding this comment.
We're not using them somewhere else.
There was a problem hiding this comment.
I have tendency to make everything hardcode in const strings in case we want to change something later then we have one place to change and we won't break something if it is repeated somewhere ;p
rafek1241
approved these changes
Feb 5, 2025
|
Thanks for the review and feedback. Could you merge the PR when you have the chance? I will review the configuration builder and documentation later. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR! I reviewed most of it and aligned a few things with the repository standards and the Service Bus module. Next, I need to take a look at the configuration builder and documentation. If we can merge these suggestions, that would be great. I'll try to review the remaining parts by tomorrow or the day after. Let me know what you think.