#to_global_id should accept params #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be a simple change. Would you like to submit a pull request? 😄 |
|
Sure, no problem. |
|
@kaspth Look good? |
| @@ -11,7 +11,9 @@ class << self | |||
|
|
|||
| def create(model, options = {}) | |||
| if app = options.fetch(:app) { GlobalID.app } | |||
| new URI::GID.create(app, model), options | |||
| params = options.except(:app, :verifier, :for) | |||
| params = nil if params.empty? # Prevent trailing ? mark | |||
There was a problem hiding this comment.
This should be handled in URI::GID.
|
Mostly, but can you squash your commits? 😄 |
|
Squashed |
kaspth
added a commit
that referenced
this pull request
Jun 16, 2015
#to_global_id should accept params
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
URI::GID.createallows params, it seems like#to_global_idwould accept a params hash. This would be convenient for non-standard cases like multiple databases.