Rotate damping #251
Merged
Rotate damping #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
Closed
ramokz
added a commit
that referenced
this pull request
Apr 25, 2024
* Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Fixed issue with grabbing active_pcam in viewfinder.gd * Minor updates * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Updated .import files * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Minor updates * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * Damping 2.0 (#248) * Smooth damp for phantom_camera_3D.gd * Minor 3D damping updates * Added Smooth Damp to phantom_camera_2D.gd - [Updated] Minor things for 3D smooth damp system * Re-added physics interpolation to 2D script * Removed Smoothing nodes and improved 2d documentation * Rotate damping (#251) * Fixed incorrect name and added type to variable * Fixed issue with look_at method not being called * Added Look At Damping properties * Changed _set_velocity to _set_follow_velocity * Added Look At damping * Updated damping default values * Added conditional look_at_damping * Added damping to LookAt Group * Minor property updater fixes * Removed unneeded variable * Added range slider to Look At Damping * Added additional look_at checks * smooth_damp function parameter alignment * Minor Group Look At fix * Removed unused variables * Corrected fixed camera angle tween duration * Fixed issue with tweening 2D zoom * Made player model be set to top level * Made playable_character_2d.tscn its own scene * Updated default 2D follow_damping_value * Added playable_character_3d * Updated remaining example scenes and scripts * Updated room limit script * Updated dev_scene_3d * Renamed 2d_trigger_area * Fixed tween issue in 3DExampleScene.tscn * Removed documentation comment from _is_active * Updated tween_onload to tween_on_load * Updated examples scenes with tween_on_load rename * Minor CharacterController changes * Whitespace removal * Renamed core scripts [Renamed] phantom_camera_2D.gd to phantom_camera_2d.gd [Renamed] phantom_camera_3D.gd to phantom_camera_3d.gd * Renamed camera_3D_resource - [Renamed] Renamed camera_3D_resource to camera_3d_resource.gd * Renamed UpdateButton.tscn - [Renamed] UpdateButton.tscn to update_button.tscn * Renamed phantom_camera_gizmo_plugin_3D.gd - [Renamed] phantom_camera_gizmo_plugin_3D.gd to phantom_camera_gizmo_plugin_3d.gd * Renamed CustomGizmo.gd - [Renamed] CustomGizmo.gd to custom_gizmo.gd * Renamed example scenes to use snake_case * Renamed image assets and remaining scenes --------- Co-authored-by: Timur Turatbekov <44378225+P5ina@users.noreply.github.com> Co-authored-by: ZenithStar <zenithstar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #250